Ismael, by using sourceIndex you’re assuming that the elements of the document are static. But Rob said he has things that are “written out to the DOM.” His WYSIWYG editor is obviously dynamically inserting and removing elements, which destroys the correlation between sourceIndex and the original element.

Instead, I think you need to use either the id of the element (if it already has one) or generate your own id. I know this has its own assumptions, namely 1) there are no duplicate ids in the document and 2) the ids will not be changed dynamically. However, this seems less risky to me than assuming every element in the DOM will always be in the same ordinal position.

Also, I know this stuff is a few years old. Do you have any recommendations for a more current discussion on this topic? Do you think by now we can start forgetting IE5?

Me podrías decir como podría hacer para que cuando cargue la pagina se abra un submenu en concreto?

I used to use the following functions which do not give me the same problems that I am currently having with your functions. I swapped over to use your functions after reading about the problems they fix that the others didn’t and they have worked
elsewhere perfectly until now with this particular issue.

//old functions that work
function addEvent( obj, type, fn ){
if ( obj.attachEvent ) {
obj[’e'+type+fn] = fn;
obj[type+fn] = function(){obj[’e'+type+fn]( window.event );}
obj.attachEvent( ‘on’+type, obj[type+fn] );
}else
obj.addEventListener( type, fn, false );
}

function removeEvent( obj, type, fn ) {
if ( obj.detachEvent ) {
obj.detachEvent( ‘on’+type, obj[type+fn] );
obj[type+fn] = null;
}else
obj.removeEventListener( type, fn, false );
}

The problem is with a WYSIWYG HTML editor that is instantiated on an onclick event and written out to the DOM.
I am looping through all my toolbar buttons adding onclick event handlers to each button in turn.
To take one button in particular the HTML format is this (from IE’s generated source)

I am looping through an array of all my buttons within an editor method and adding the event handler like so

Editor.prototype.Create = function()
{
//some other code
var self = this;
//loop through all buttons in turn
elem = document.getElementById(buttonID);
addEvent( elem, ‘click’, function(){ShowDebug(’Button 2 OnClick’);self.FormatText(this.id,n);} )

}

// I have also tried this for buttons I know the ID for.

elem = document.getElementById(’ViewText’);
addEvent( elem, ‘click’, function(){ShowDebug(’Button 2 OnClick’);self.FormatText(’ViewText’,n);} );

The event handler seems to be added correctly (from firebuglite debug in IE - I have put some debug into your addEvent function handler when
using attachEvent)

function addEvent(obj,evType,func){
var r = false;
if(obj.addEventListener){
obj.addEventListener(evType, func, false);
r = true;
}else if (obj.attachEvent) {
var id = obj.sourceIndex || -1;
ShowDebug(”addEvent to ” + id);
if (!func[evType + id]) {
var f = func[evType + id] = function(e) {
var o = document.all[id] || document;
o._f = func;
var s = o._f(e);
o._f = null;
return s;
};
ShowDebug(”obj = ” + obj + ” typeof = ” + typeof(obj) + ” obj.id = ” + obj.id + ” tagName = ” + obj.tagName);
r = obj.attachEvent(”on” + evType, f);
obj = null;
}
}else{ //if there is already a function for this handler call beforehand
var ev=”on”+evType;
var oldevent = obj[ev];
if (typeof oldevent != “function”){
obj[ev]=func;
}else{
obj[ev] = function(){ oldevent();func();}
}
}
return r;
};

1: addEvent to 628
2: obj = [object] typeof = object obj.id = ViewText tagName = IMG

The problem comes whenever I try to click on any of the toolbar buttons. Instead of passing through the reference to the actual IMG tag which it should be doing its passing through the reference for the node above which is the SPAN tag.

// INCORRECT!!!
25: Button 2 Onclick
26: IN FormatText HTMLModeCMStextarea ; CMStextarea ;

Whereas it should be passing though (as Firefox correctly does) the ID for the IMG tag.

// CORRECT!!!
11: Button 2 OnClick
12: IN FormatText ViewSource ; CMStextarea ;

If I revert back to the older functions it works fine. Can you give me some guidance on whats gone wrong and if there is a fix about?

Thanks